feat(go): add retries for IPC failures#147
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Go Snowflake driver to support retry-based handling for Arrow IPC/stream read failures (and related cancellation/error-propagation improvements), primarily by bumping gosnowflake to v2.1.0 and wiring/configuring stream retry behavior across the driver.
Changes:
- Bump dependencies (notably
github.com/snowflakedb/gosnowflake/v2tov2.1.0, plus driverbase-go modules) to pick up upstream stream retry/cancel improvements. - Expose and trace the statement-level
OptionStreamRetryEnabledsetting (so callers/tests can observe and debug retry mode). - Adjust GetObjects metadata population and test quirks to align with updated driverbase/validation expectations.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go/statement.go | Adds GetOption support for OptionStreamRetryEnabled at statement scope. |
| go/record_reader.go | Adds tracing for record reader construction (includes retry-enabled attribute). |
| go/go.mod | Bumps gosnowflake + driverbase-go dependencies to newer versions. |
| go/go.sum | Updates checksums for bumped module versions. |
| go/driver_test.go | Updates test quirks to advertise SupportsGetTableSchema(). |
| go/database.go | Refactors //nolint placement to target deprecated gosnowflake config fields more precisely. |
| go/connection.go | Uses driverbase.Nullable(...) when populating XDBC type fields in GetObjects output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Any feedback on this one @zeroshade or @lidavidm ? |
lidavidm
approved these changes
Jun 11, 2026
|
✔️ Test passed: davidhcoe/adbc-drivers-snowflake@877bb3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed